Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spark] [Test only] Fix Spark Master test in DeltaSourceSuite #3088

Merged

Conversation

scottsand-db
Copy link
Collaborator

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

Fix and re-enable a failing delta-spark test against Spark Master in DeltaSourceSuite

How was this patch tested?

Test only change.

@scottsand-db scottsand-db self-assigned this May 13, 2024
.selectExpr(
"id",
"id2",
"CASE WHEN id3 = 'null' THEN NULL ELSE cast(id3 as long) END as id3")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the behavior of cast changed in Spark master? Why do we need this change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it did change. Spark Master enables ANSI SQL mode by default

@scottsand-db scottsand-db merged commit b1b84d5 into delta-io:master May 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants